[Twisted-Python] setup.py broken in trunk

[Glyph Lefkowitz]

41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip install -e .' (and indeed, 'pip install .') no longer installs 'twist'.

I think we should revert this.

Clearly we have a problem with our test suite, if we're not catching the binaries disappearing on us :-).

-glyph

[Adi Roiban]

Yes. Will revert it. My fault for not correctly solving the conflicts
during merge.

Post by Glyph Lefkowitz
41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip install -e .' (and indeed, 'pip install .') no longer installs 'twist'.
I think we should revert this.
Clearly we have a problem with our test suite, if we're not catching the binaries disappearing on us :-).
-glyph
_______________________________________________
Twisted-Python mailing list
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Adi Roiban]

Post by Glyph Lefkowitz
41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip install -e .' (and indeed, 'pip install .') no longer installs 'twist'.
I think we should revert this.
Clearly we have a problem with our test suite, if we're not catching the binaries disappearing on us :-).

I have reverted and re-submitted the ticket for review. Sorry for the trouble!

I have not yet added integration tests for the console scripts.

I think that before writing such tests we need to make sure that
development environments and CI environments all have `pip install -e
.` or something similar called.

For more details see https://twistedmatrix.com/trac/ticket/8622#comment:8

Craig is pushing for removing bin/trial and after bin/trial is removed
I think that all environments will need to have `pip install .` called
so that we don't run the OS trial version.

There is also ticket https://twistedmatrix.com/trac/ticket/8544 which
tries to create tox environments for all Buildbot builders so that we
can run everything with Tox on buildbot CI system.

[Glyph Lefkowitz]

Post by Adi Roiban

Post by Glyph Lefkowitz
41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip install -e .' (and indeed, 'pip install .') no longer installs 'twist'.
I think we should revert this.
Clearly we have a problem with our test suite, if we're not catching the binaries disappearing on us :-).

I have reverted and re-submitted the ticket for review. Sorry for the trouble!

Thanks for fixing!

Post by Adi Roiban
I have not yet added integration tests for the console scripts.
I think that before writing such tests we need to make sure that
development environments and CI environments all have `pip install -e
.` or something similar called.
For more details see https://twistedmatrix.com/trac/ticket/8622#comment:8
Craig is pushing for removing bin/trial and after bin/trial is removed
I think that all environments will need to have `pip install .` called
so that we don't run the OS trial version.
There is also ticket https://twistedmatrix.com/trac/ticket/8544 which
tries to create tox environments for all Buildbot builders so that we
can run everything with Tox on buildbot CI system.

Once we have `tox` everywhere, we don't need a separate step to run `pip`. This seems like the right way to address it.

-g