[Twisted-Python] [BACKWARDS INCOMPATIBILITY] Making twisted.python.dist3 private

[Amber "Hawkie" Brown]

Hi everyone,

I am moving the dist3 from a whitelist to a blacklist, and that requires changing the whole module's interface, which shouldn't be public anyway.

You can get the branch here: https://github.com/twisted/twisted/pull/501 , it'll be available for a further week.

The only concern for this code was depgraph, which we are now at the point of not needing, as we're getting to leaf modules and not core modules.

- Amber

[Adi Roiban]

+1 for the change.

Thanks!

On 16 August 2016 at 08:20, Amber "Hawkie" Brown

Post by Amber "Hawkie" Brown
Hi everyone,
I am moving the dist3 from a whitelist to a blacklist, and that requires changing the whole module's interface, which shouldn't be public anyway.
You can get the branch here: https://github.com/twisted/twisted/pull/501 , it'll be available for a further week.
The only concern for this code was depgraph, which we are now at the point of not needing, as we're getting to leaf modules and not core modules.
- Amber
_______________________________________________
Twisted-Python mailing list
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Glyph Lefkowitz]

+1 from me as well.

It's just weird that we ever made that module public in the first place.
This change will make a lot harder to accidentally add some new code and make it python2 only (which we should not be doing at this point!).
It will be encouraging progress-wise to visibly see this list shrink, rather than an indeterminate-sized list grow.

Post by Adi Roiban
+1 for the change.
Thanks!
On 16 August 2016 at 08:20, Amber "Hawkie" Brown

Post by Amber "Hawkie" Brown
Hi everyone,
I am moving the dist3 from a whitelist to a blacklist, and that requires changing the whole module's interface, which shouldn't be public anyway.
You can get the branch here: https://github.com/twisted/twisted/pull/501 , it'll be available for a further week.
The only concern for this code was depgraph, which we are now at the point of not needing, as we're getting to leaf modules and not core modules.
- Amber
_______________________________________________
Twisted-Python mailing list
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

--
Adi Roiban
_______________________________________________
Twisted-Python mailing list
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python