[Twisted-Python] INCOMPATIBLE CHANGE: Removing hotshot from twistd's profiler support

[Amber "Hawkie" Brown]

Hotshot is completely broke, and it doesn't exist in Python 3. It is currently the default for twistd and since it doesn't work, we should just sidestep the deprecation cycle and remove it, changing the default to something useful.

The ticket with the changes are available on https://twistedmatrix.com/trac/ticket/5137 . The branch attached to it removes HotshotProfiler and amends the default to be cProfile, which is the most useful for users.

In accordance with the policy (https://twistedmatrix.com/trac/wiki/CompatibilityPolicy#ProcedureforExceptionstothisPolicy), this will remain unmerged for at least a week, and requires three signoffs by committers.

Amber "Hawkie" Brown
GPG: https://keybase.io/hawkowl

[Glyph]

Post by Amber "Hawkie" Brown
Hotshot is completely broke, and it doesn't exist in Python 3. It is currently the default for twistd and since it doesn't work, we should just sidestep the deprecation cycle and remove it, changing the default to something useful.
The ticket with the changes are available on https://twistedmatrix.com/trac/ticket/5137 . The branch attached to it removes HotshotProfiler and amends the default to be cProfile, which is the most useful for users.
In accordance with the policy (https://twistedmatrix.com/trac/wiki/CompatibilityPolicy#ProcedureforExceptionstothisPolicy), this will remain unmerged for at least a week, and requires three signoffs by committers.

You've got my sign-off. I can't imagine the hypothetical scenario where the current behavior would be useful; according to Zooko's comment on that ticket it's already broken if you're using a supported version of Python.

-glyph

[Kevin Turner]

+1 to removing hotshot.

It's hard enough to figure out how to profile python applications
without having broken defaults in the mix.