[Twisted-Python] making appveyor a required status

Discussion:

Glyph Lefkowitz

2016-08-13 23:40:50 UTC

Just a bit of Github housekeeping: Appveyor has looked pretty stable (more than our other Windows builds, even). I'm thinking about making it a required status for merging. But I'm curious what other folks have seen on PRs I might not have looked at; is it pretty reliable at this point?

Also: I am thinking of turning off push statuses for Travis (for every branch but trunk), and just making it PR statuses. Is anyone using the push status, or is it just making builds take twice as long?

-glyph

Adi Roiban

2016-08-14 10:38:45 UTC

Permalink

Post by Glyph Lefkowitz
Just a bit of Github housekeeping: Appveyor has looked pretty stable (more than our other Windows builds, even). I'm thinking about making it a required status for merging. But I'm curious what other folks have seen on PRs I might not have looked at; is it pretty reliable at this point?

+1 for enforcing Windows tests via Appveyor

I think that Appveyor are providing an excellent service... much
faster than Travis-CI.

Post by Glyph Lefkowitz
Also: I am thinking of turning off push statuses for Travis (for every branch but trunk), and just making it PR statuses. Is anyone using the push status, or is it just making builds take twice as long?

+1 for having Travis-CI run push tests only on trunk.

I will come back with more details in a separate email.

Cheers

--
Adi Roiban

Adi Roiban

2016-08-17 15:07:17 UTC

Permalink

Appveyor Twisted jobs are still running under my account. There is a
ticket to fix this [1] ... but I don't know how to create organization
accounts ... other than sharing the same username and password

As the tests are executed under a private account, I am the only
person who can trigger a rebuild... and I have just saw Appveyor tests
failing and then passing on a re-run with the same code.

[1] https://twistedmatrix.com/trac/ticket/8708

--
Adi Roiban