[Twisted-Python] Buildbot upgrade to latest eight branch

[Adi Roiban]

Hi,

I have updated the version of buildbot used by
https://buildbot.twistedmatrix.com

it used to be an old forked version with some patches... but the fork did
not had good documentation.

To move things forward I have discarded the forked changes and went for
upstream version.

The changes were done in this PR
https://github.com/twisted-infra/braid/pull/205

The changes will allow us to use the new upstream code for GitHub <->
Buildbot integration ... aka webhooks and commit status reports.

This might introduce retrogressions and things might start to fall.
Please report any errors you see when interacting with buildbot here, over
#twisted-admin or by creating a new issue here
https://github.com/twisted-infra/braid/issues

Have a good day!

[Glyph]

Hi,
I have updated the version of buildbot used by https://buildbot.twistedmatrix.com <https://buildbot.twistedmatrix.com/>
it used to be an old forked version with some patches... but the fork did not had good documentation.
To move things forward I have discarded the forked changes and went for upstream version.
The changes were done in this PR https://github.com/twisted-infra/braid/pull/205 <https://github.com/twisted-infra/braid/pull/205>
The changes will allow us to use the new upstream code for GitHub <-> Buildbot integration ... aka webhooks and commit status reports.
This might introduce retrogressions and things might start to fall.
Please report any errors you see when interacting with buildbot here, over #twisted-admin or by creating a new issue here https://github.com/twisted-infra/braid/issues <https://github.com/twisted-infra/braid/issues>

Thanks a lot for doing this, Adi! The less random infrastructure forks we maintain, the easier it gets to manage the burden of operating all this stuff...

-glyph

[Adi Roiban]

Reporting the build status from Buildbot to GitHub was deployed into
production using the branch which is waiting a review before being merged
in master

https://github.com/twisted-infra/braid/pull/206

Please report any feedback or issues with the GitHub commit status reports
in the PR

Thanks!

[Glyph]

Reporting the build status from Buildbot to GitHub was deployed into production using the branch which is waiting a review before being merged in master
https://github.com/twisted-infra/braid/pull/206 <https://github.com/twisted-infra/braid/pull/206>
Please report any feedback or issues with the GitHub commit status reports in the PR

Woohoo!

-glyph

[Adi Roiban]

Post by Adi Roiban
https://github.com/twisted-infra/braid/pull/206

I'll try to review this this weekend.

I have merged the GitHub commit status as I think that it was working OK.

I have now deployed the GitHub Hooks build trigger changes.

Build are automatically triggered for all pushes in all branches. There is
a delay of 5 seconds so that multiple builds pushed in the same time will
only trigger a single build for the last commit.

See this PR for details and if you want to review it :)

https://github.com/twisted-infra/braid/pull/208

With this change, Buildbot should have a closer behavior to Travis-CI. That
is, it will automatically start the builders and will report the build
results in GitHub PR.

Happy hacking :)

[Cory Benfield]

With this change, Buildbot should have a closer behavior to Travis-CI. That is, it will automatically start the builders and will report the build results in GitHub PR.

I spotted this in action today before I’d read this list post, so I just want to say: thanks so much for this Adi! This is one of those little changes that makes life a great deal nicer for me as a reviewer *and* contributor: not needing to do the dance with forcing the buildbots to run is really excellent.

Cory

[Adi Roiban]

Post by Adi Roiban
With this change, Buildbot should have a closer behavior to Travis-CI.

That is, it will automatically start the builders and will report the build
results in GitHub PR.
I spotted this in action today before I’d read this list post, so I just
want to say: thanks so much for this Adi! This is one of those little
changes that makes life a great deal nicer for me as a reviewer *and*
contributor: not needing to do the dance with forcing the buildbots to run
is really excellent.

With this change you no longer have to create duplicate PR for "imported"
branches . Just create the branch and Travis and Buildbot will
automatically do their job and you can merge the "imported" branch without
a PR.

"Imported" branch is a branch hosted in the Twisted main repo but which
contains changes merged from a forked repo.