[Twisted-Python] process changes causing buildbot failures on win7?

Discussion:

Glyph Lefkowitz

2015-10-09 22:27:59 UTC

These failures:

===============================================================================
[FAIL]
Traceback (most recent call last):
File "C:\Users\Build Slave\bot-glyph-6\windows7-64-py2.7-select\Twisted\twisted\internet\test\test_process.py", line 361, in test_systemCallUninterruptedByChildExit
self.assertEqual(result, ["Foo\n"])
File "C:\Users\Build Slave\bot-glyph-6\windows7-64-py2.7-select\Twisted\twisted\trial\_synctest.py", line 437, in assertEqual
super(_Assertions, self).assertEqual(first, second, msg)
File "C:\Python27\Lib\unittest\case.py", line 513, in assertEqual
assertion_func(first, second, msg=msg)
File "C:\Python27\Lib\unittest\case.py", line 742, in assertListEqual
self.assertSequenceEqual(list1, list2, msg, seq_type=list)
File "C:\Python27\Lib\unittest\case.py", line 724, in assertSequenceEqual
self.fail(msg)
twisted.trial.unittest.FailTest: Lists differ: [''] != ['Foo\n']

First differing element 0:

Foo

- ['']
+ ['Foo\n']

twisted.internet.test.test_process.ProcessTestsBuilder_IOCPReactorTests.test_systemCallUninterruptedByChildExit
twisted.internet.test.test_process.ProcessTestsBuilder_SelectReactorTests.test_systemCallUninterruptedByChildExit
twisted.internet.test.test_process.ProcessTestsBuilder_Win32ReactorTests.test_systemCallUninterruptedByChildExit

have started happening on the buildbot on trunk: https://buildbot.twistedmatrix.com/builders/windows7-64-py2.7/builds/5215/steps/select/logs/problems

soon after this change: http://twistedmatrix.com/trac/changeset/45725

Unfortunately the buildbot was in a kind of unrelated bad state when it landed, and the configuration is a bit different now, so I'm not sure if this is a regression or a configuration error. But given that the change was about processes, and the failure is in the process test, I thought it might bear some investigation...

-glyph

Hawkie

2015-10-10 03:36:21 UTC

Permalink

It's because the Windows tests (that one) can't cope with spaces in the exe name, and now it's in a virtual env, that's popped up.

The Python 3.5 branch has a fix for this, as the Windows 3.5 builder was the first to show this problem.

-hawkie

Post by Glyph Lefkowitz
===============================================================================
[FAIL]
File "C:\Users\Build Slave\bot-glyph-6\windows7-64-py2.7-select\Twisted\twisted\internet\test\test_process.py", line 361, in test_systemCallUninterruptedByChildExit
self.assertEqual(result, ["Foo\n"])
File "C:\Users\Build Slave\bot-glyph-6\windows7-64-py2.7-select\Twisted\twisted\trial\_synctest.py", line 437, in assertEqual
super(_Assertions, self).assertEqual(first, second, msg)
File "C:\Python27\Lib\unittest\case.py", line 513, in assertEqual
assertion_func(first, second, msg=msg)
File "C:\Python27\Lib\unittest\case.py", line 742, in assertListEqual
self.assertSequenceEqual(list1, list2, msg, seq_type=list)
File "C:\Python27\Lib\unittest\case.py", line 724, in assertSequenceEqual
self.fail(msg)
twisted.trial.unittest.FailTest: Lists differ: [''] != ['Foo\n']
Foo
- ['']
+ ['Foo\n']
twisted.internet.test.test_process.ProcessTestsBuilder_IOCPReactorTests.test_systemCallUninterruptedByChildExit
twisted.internet.test.test_process.ProcessTestsBuilder_SelectReactorTests.test_systemCallUninterruptedByChildExit
twisted.internet.test.test_process.ProcessTestsBuilder_Win32ReactorTests.test_systemCallUninterruptedByChildExit

have started happening on the buildbot on trunk: https://buildbot.twistedmatrix.com/builders/windows7-64-py2.7/builds/5215/steps/select/logs/problems
soon after this change: http://twistedmatrix.com/trac/changeset/45725
Unfortunately the buildbot was in a kind of unrelated bad state when it landed, and the configuration is a bit different now, so I'm not sure if this is a regression or a configuration error. But given that the change was about processes, and the failure is in the process test, I thought it might bear some investigation...
-glyph

Glyph Lefkowitz

2015-10-10 08:44:49 UTC

Permalink

Aaaaand, it's fixed :)

https://twistedmatrix.com/trac/ticket/8046#comment:4

Thanks!

-glyph

Post by Hawkie
It's because the Windows tests (that one) can't cope with spaces in the exe name, and now it's in a virtual env, that's popped up.
The Python 3.5 branch has a fix for this, as the Windows 3.5 builder was the first to show this problem.
-hawkie

Post by Glyph Lefkowitz

_______________________________________________
Twisted-Python mailing list
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python