[Twisted-Python] Welcome to the "Twisted-Python" mailing list

[Adam Wozniak]

This is a problem in twisted. Buldbot uses twisted.

To make buildbot git polling work for me, I had to make the change below.

Based on zturner comment #17 in
http://trac.buildbot.net/ticket/2936

Win 10 Pro, Version 1703, OS Build 15063.138, 64 bit
Python 2.7
Buildbot version: 0.9.5
Twisted version: 17.1.0


$ diff -uprN _dumbwin32proc.py.orig _dumbwin32proc.py
--- _dumbwin32proc.py.orig 2017-04-18 08:25:31.639822200 -0700
+++ _dumbwin32proc.py 2017-04-18 08:25:43.310989300 -0700
@@ -210,7 +210,7 @@ class Process(_pollingfile._PollingTimer
# TODO: error detection here. See #2787 and #4184.
def doCreate():
self.hProcess, self.hThread, self.pid, dwTid = win32process.CreateProcess(
- command, cmdline, None, None, 1, 0, env, path, StartupInfo)
+ None, cmdline, None, None, 1, 0, env, path, StartupInfo)
try:
try:
doCreate()

[Jean-Paul Calderone]

Post by Adam Wozniak
This is a problem in twisted. Buldbot uses twisted.
To make buildbot git polling work for me, I had to make the change below.
Based on zturner comment #17 in
http://trac.buildbot.net/ticket/2936

I left a comment on that ticket forwarding the straightforward fix that can
be applied to BuildBot to address this problem.

It's certainly true that there are shortcomings in the spawnProcess API so
I won't try to argue that this *isn't* a problem in Twisted. However, some
of those very problems make it difficult to *fix* any of the problems. It
seems more likely that spawnProcess will eventually be replaced by a better
API (if the problems are ever fixed at all, that is). Meanwhile, since the
fix in BuildBot is quite simple, that seems like a good direction to pursue.

Jean-Paul

[Glyph Lefkowitz]

Post by Adam Wozniak
This is a problem in twisted. Buldbot uses twisted.
To make buildbot git polling work for me, I had to make the change below.
Based on zturner comment #17 in
http://trac.buildbot.net/ticket/2936 <http://trac.buildbot.net/ticket/2936>
I left a comment on that ticket forwarding the straightforward fix that can be applied to BuildBot to address this problem.
It's certainly true that there are shortcomings in the spawnProcess API so I won't try to argue that this isn't a problem in Twisted. However, some of those very problems make it difficult to fix any of the problems. It seems more likely that spawnProcess will eventually be replaced by a better API (if the problems are ever fixed at all, that is). Meanwhile, since the fix in BuildBot is quite simple, that seems like a good direction to pursue.

spawnProcess may remain a useful primitive for something higher-level, or it might be replaced, but there has been some discussion of what that might be for quite some time:

https://twistedmatrix.com/trac/ticket/2415 <https://twistedmatrix.com/trac/ticket/2415>

Getting some new momentum on that ticket would be good.

-g