[Twisted-Python] SSl wincertstore Ticket 6371

[John Aherne]

The failure is in test_agent

test_setsTrustRootOnContextDefaultTrustRoot

This fails if wincertstore is available with this failure:-

twisted.trial.unittest.FailTest:
<twisted.internet._sslverify.OpenSSLWindowsCertificateAuthorities object at
0x037DB2B0> is not an instance of <class
'twisted.internet._sslverify.OpenSSLDefaultPaths'>


This is because the patch from aaron which I have applied
has_sslverify.platformTrust check for wincertstore and does not return
OpenSSLDefaultPaths but returns
_sslverify.OpenSSLWindowsCertificateAuthorities

The solution I followed was to add a test to specifically check for a
return of OpenSSLWindowscertificateAuthorities if wincertstore was
available otherwise to skip it.

The other part was to skip the test for
test_setsTrustRootOnContextDefaultTrustRoot
if wincertstore was available

The error message comes from the tests for the root name servers.

I just need to fix that so I have a clean test run before making any
changes.

I just can't see what the problem is with the error

Thanks

[John Aherne]

I have done a clean download of twisted and run the tests without any
changes.

I still get the same error on:--

twisted.names.test.test_tap.OptionsTests.test_recursiveConfiguration

[ERROR]
Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 0x4507698 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('d.root-servers.net', <Deferred at 0x4507c88>)>
<DelayedCall 0x450cd28 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('l.root-servers.net', <Deferred at 0x450ce68>)>
<DelayedCall 0x873e878 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('e.root-servers.net', <Deferred at 0x873e058>)>
<DelayedCall 0x873e580 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('f.root-servers.net', <Deferred at 0x873e6e8>)>
<DelayedCall 0x43d8350 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('h.root-servers.net', <Deferred at 0x43d86e8>)>
<DelayedCall 0x450cf08 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('m.root-servers.net', <Deferred at 0x450cd78>)>
<DelayedCall 0x4507d28 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('a.root-servers.net', <Deferred at 0x4507cb0>)>
<DelayedCall 0x4507620 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('b.root-servers.net', <Deferred at 0x4507328>)>
<DelayedCall 0x45074e0 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('c.root-servers.net', <Deferred at 0x45072b0>)>
<DelayedCall 0x43d8c10 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('g.root-servers.net', <Deferred at 0x873e8f0>)>
<DelayedCall 0x43d82b0 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('i.root-servers.net', <Deferred at 0x43d8800>)>
<DelayedCall 0x43d8558 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('j.root-servers.net', <Deferred at 0x43d8508>)>
<DelayedCall 0x43d0378 [60.0s] called=0 cancelled=0
ThreadedResolver._cleanup('k.root-servers.net', <Deferred at 0x43d83c8>)>

twisted.names.test.test_tap.OptionsTests.test_recursiveConfiguration
-------------------------------------------------------------------------------
Ran 11183 tests in 109.669s

FAILED (skips=2945, errors=1, successes=8237)

[Glyph]

I have done a clean download of twisted and run the tests without any changes.

OK. This is a bug we should investigate, but I think we can safely say it's a separate bug and not one which will cause your patch to fail review.

-glyph